Edge Rewrite
// HTMLRewriter · presentation

This page was redesigned at the edge.

Cloudflare fetched the original article and streamed it through HTMLRewriter to apply an entirely new visual system without rebuilding the source page.

Jump to content

Template talk:Right

Page contents not supported in other languages.
Add topic
From Wikipedia, the free encyclopedia
Latest comment: 7 years ago by Evad37 in topic span instead of div

Broken

[edit]

@Frietjes: Today the changes made in 2015 break my talk page. The transcluded page User:Tangotango/RfA Analysis/Report is empty, which means that a stray piece of mark-up suddenly, and apparently randomly, appeared at the top of my talk page. I'm not sure if making this follow the overloaded design of {{Left}} is a good idea.

All the best: Rich Farmbrough, 20:13, 19 October 2017 (UTC).Reply

I see no reason why {{right}} and {{left}} shouldn't function the same. the userspace page User:Tangotango/RfA Analysis/Report is a redirect to User:Cyberpower678/RfX Report. that page is empty because there are no open RFA or RFB discussions and someone blanked it. Frietjes (talk) 20:20, 19 October 2017 (UTC)Reply

So {{Right}} looks like this

This is not good design.

All the best: Rich Farmbrough, 22:47, 3 November 2017 (UTC).Reply

span instead of div

[edit]

I have changed this template (and {{left}}) to use span tags instead of div tags in order to avoid Special:LintErrors/misc-tidy-replacement-issues, which shows up when div tags are wrapped inside of span tags. Since this template appears to apply only to in-line content, span should be appropriate. Let me know if I have broken anything. – Jonesey95 (talk) 12:17, 23 August 2018 (UTC)Reply

Jonesey95 made two edits:

And we have Template talk:Infobox element isotopes, which includes four uses like

  • {{right|1={{Infobox element/element navigation|....}}}}

Which, after Jonesey95's contributions, evaluates to <span> ... <div>...</div> ... </span> ... so now what? One can easily fix Template talk:Infobox element isotopes to use other-than-span markup to replace {{right}}, but I wonder how many more of these there are, where Jonesey95's edit of {{right}} created new errors. —Anomalocaris (talk) 04:54, 14 September 2018 (UTC)Reply

Yes. There are definitely new errors, but many fewer than before. See Template talk:Left for a similar discussion (pinging Evad37). The more I look at this template, {{left}}, and {{small}}, the more I think that these templates need a |div=yes option that deploys <div>...</div> tags instead of span tags. Or, if forking templates is your thing, a "left div", "right div", "small div" etc. templates (although, for example, {left div} would probably be better as a shortcut for to {left|div=yes} to avoid too much forking). Thoughts? – Jonesey95 (talk) 09:04, 14 September 2018 (UTC)Reply
I wonder if its worth using Lua to inspect the passed in content, and automatically switch to a <div> instead of a <span> if the content contains a <div> or other block elements. - Evad37 [talk] 09:15, 14 September 2018 (UTC)Reply