Module talk:Current events calendar
Add topicI assume this is called without parameters as:
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
| 1 | 2 | 3 | 4 | |||
| 5 | 6 | 7 | 8 | 9 | 10 | 11 |
| 12 | 13 | 14 | 15 | 16 | 17 | 18 |
| 19 | 20 | 21 | 22 | 23 | 24 | 25 |
| 26 | 27 | 28 | 29 | 30 | 31 |
Nowiki
[edit]Might as well have a simple nowiki option for debugging:
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
| 1 | 2 | 3 | 4 | |||
| 5 | 6 | 7 | 8 | 9 | 10 | 11 |
| 12 | 13 | 14 | 15 | 16 | 17 | 18 |
| 19 | 20 | 21 | 22 | 23 | 24 | 25 |
| 26 | 27 | 28 | 29 | 30 | 31 |
Cells completed at end of the last week
[edit]@Mr. Stradivarius: I replaced the break command in the script with a value assignment in order to have the cells completed for the final row of the calendar. The lack of such a complete set of cells becomes an issue when there is CSS that overrides the display=table with display=block. This is a step towards resolving the over-wide column on mobile. Please review at your convenience. — RossO (talk) 17:30, 28 August 2017 (UTC)
- Looks good to me. Nice work. :) — Mr. Stradivarius ♪ talk ♪ 13:06, 29 August 2017 (UTC)
Cells completed at start of first week, loops combined
[edit]@Mr. Stradivarius: I used the same technique as above to replace the colspan logic on the first week with real cells. The trick was to use a less-than-zero value for the cell counts. Once that was in place, I was able to create identical logic for the first week row as the remaining week rows. I then combined that logic into a single while loop, and removed ~20 lines of code, and eliminated a few local variables. Finally I used a ternary assignment to reduce some more overhead.
Would you mind reviewing the sandbox and perhaps testing it against some problem months or scenarios? I don't think this applies any new logic but I don't have any test cases to proof against. Thank you (as always) for your time. Once I get your review, I will push it onto the live version. — RossO (talk) 19:55, 29 August 2017 (UTC)
@Mr. Stradivarius: My spot testing shows that the calendar operates correctly for the current use on Portal:Current events. I have moved the Sandbox version to the production page. — RossO (talk) 18:44, 1 September 2017 (UTC)