Edge Rewrite
Jump to content

Module talk:Graphic novel list

Page contents not supported in other languages.
Add topic
From Wikipedia, the free encyclopedia
Latest comment: 3 months ago by Ahecht in topic Unnecessary Linebreak

Unnecessary Linebreak

[edit]

@Ahecht: There is a minor bug with the output in p._row. On line 116, you have the module output a linebreak if {{{TranslitTitle}}} or {{{OriginalTitle}}} are defined regardless of whether {{{LicensedTitle}}} or {{{Title}}} are defined. This creates unnecessary whitespace when those parameters are empty (see List of Monogatari novels as an example). Perhaps the output for {{{LicensedTitle}}} or {{{Title}}} and the following linebreak should be nested within its own if...then statement, such as:

if hasTitle then
    out('<td style="text-align:left;">')

    if notBlank(args.LicensedTitle) or notBlank(args.Title) then
        out('<i>')
		out(firstNotBlank(args.LicensedTitle, args.Title))
		out('</i>')

		if notBlank(args.TranslitTitle) or notBlank(args.OriginalTitle) then
			out('<br/>')
		end
    end
...

I have limited understanding of Lua, but I believe that will preserve the left alignment of the cell while removing the unnecessary whitespace. I also removed the or '' as unnecessary since the code only executes if {{{LicensedTitle}}} or {{{Title}}} are defined. — Jkudlick ⚓ (talk) 13:52, 6 July 2026 (UTC)Reply

@Jkudlick  Done --Ahecht (TALK
PAGE
)
00:04, 7 July 2026 (UTC)Reply