Edge Rewrite
Jump to content

Template talk:WikiProject banner shell

Page contents not supported in other languages.
Add topic
From Wikipedia, the free encyclopedia
(Redirected from Module talk:Banner shell/sandbox)
Latest comment: 7 days ago by PresN in topic Article/page mess continues

Cricket

[edit]

Wikipedia talk:WikiProject Cricket is currently in Category:WikiProject banners without banner shells but there is a banner shell on the page  Martin (MSGJ · talk) 12:27, 18 November 2025 (UTC)Reply

Inconsistent list ratings

[edit]

@MSGJ: There have been few cases where the Wikipedia:WikiProject Lists banner still contains |class=FL cards eg. This becomes a problem when the FACBot demotes a list. It sets |class=List in the banner shell, but this is overridden by the project. I thought (and the bot assumes) that no banners inside the banner shell should have a class card. Is this something that the Cewbot deals with? Hawkeye7 (discuss) 03:59, 13 December 2025 (UTC)Reply

WikiProject Lists has opted out of PIQA, so they set their own assessments. Yes, Cewbot should be aware of this, and will not remove class values of opt-out projects  Martin (MSGJ · talk) 08:02, 13 December 2025 (UTC)Reply
So WikiProject Lists articles retain featured list status even after a featured list removal? Hawkeye7 (discuss) 09:35, 13 December 2025 (UTC)Reply
I didn't say that. The project has opted out of PIQA so is responsible for maintaining their own assessments. I assume the project would be happy if an incorrect rating is removed but ultimately that is their business  Martin (MSGJ · talk) 14:22, 13 December 2025 (UTC)Reply
Okay, I just wanted to know if the FACBot should remove the |class=FL card after the article is delisted at FLR. I will have it leave the Wikipedia:WikiProject Lists banner alone. Hawkeye7 (discuss) 17:17, 13 December 2025 (UTC)Reply

Article/page mess continues

[edit]

Can someone work out why this keeps populating category redirects, mainly redirect and disambig article pages? (See User:RussBot/category redirect log for recent examples.) Sometimes it seems to be reading the page to override the class entry but then puts it in a redirect. The current example is Talk:Foster Hewitt Award in Category:Disambig-Class List articles not Category:Disambig-Class List pages which is harder to fix than most. A permanent fix to stop popularing the redirects would be better. Timrollpickering (talk) 09:44, 10 June 2026 (UTC)Reply

Issues are:
  • Foster Hewitt Award contains {{Sport index}} and {{disambiguation}} so it is identifying as both a set-index article and a disambiguation page.
  • {{WPBS}}'s logic says it is a set index article, hence an article.
  • {{WikiProject Lists}} has opted out so uses its own logic. Apparently it is automatically detecting it as a disambiguation page, hence page.
Probably a quick fix would be to remove either {{Sport index}} or {{disambiguation}}  Martin (MSGJ · talk) 13:05, 10 June 2026 (UTC)Reply
I've made some changes to Module:Class mask which should help bring into line the non-standard projects  Martin (MSGJ · talk) 15:12, 22 June 2026 (UTC)Reply
Minor note- post-update it seems to be inconsistent whether SIA class is honored - Talk:Characters of the Final Fantasy series is ignoring the WikiProject Video games "class=SIA" and assigning the article to the video games list category (which the bannershell template has), while Talk:List of Nintendo DS games is handling it as an SIA (both project and bannershell are SIA). I think that's what's going on? When I changed the bannershell class for both, nothing changed, though, so I'm confused what the "correct" mechanism is here. --PresN 14:16, 23 June 2026 (UTC)Reply
My brain is hurting! Characters of the Final Fantasy series is correctly identified as SIA by the banner shell, but not by VG. Wheras List of Nintendo DS games is not being identified as an SIA (I will need to check why), but VG is honouring the manual rating given. I think we need to be clear on what you expect to happen. For example, if |class=SIA but it is not actually an SIA do you want SIA to be honoured? In theory we can detect all real SIAs so we could ignore the class parameter entirely on these.  Martin (MSGJ · talk) 14:52, 23 June 2026 (UTC)Reply
List of Nintendo DS games is a list of lists so I think that is not a proper SIA  Martin (MSGJ · talk) 14:58, 23 June 2026 (UTC)Reply
Hmm. I think what makes the most sense (if possible) is 1) if there's an SIA template on the article then it counts as an SIA no matter what class is used in the talk templates. 2) if there's no SIA template on the article, then if a project template says it's a SIA, then it's an SIA for that project even if the bannershell says it's a list. That seems to follow how other classes work. If detecting the SIA template on the article is onerous, though, then I think it should work like just #2 there. I'm really fine with whatever, as long as it's clear how to indicate (talk and article) that something is an SIA. --PresN 20:46, 23 June 2026 (UTC)Reply

Also mentioned here: Template talk:WikiProject Department of Fun#Links to assessment categories  Martin (MSGJ · talk) 22:33, 14 June 2026 (UTC)Reply

Bit of an update to this, but doing some digging it appears if Template:Set index article is present on the article's page, it turns off the ability to classify articles as SIAs regardless if the project uses them or not, a reversal of what it was doing prior.--Kung Fu Man (talk) 12:36, 13 July 2026 (UTC)Reply

Looking at the change to Module:Class mask that precipitated this, I see that the old code around SIAs was:
				elseif grade=='list' or grade=='sia' or grade=='si' or grade=='sl' then-- List
					if args['list']~='no' then
						out = 'List'
e.g. if grade = sia, then class mask always said the page was a "List" (unless you call the module with |list=no)
The current code, however, is
		elseif pagetype=='article' then
			[...]
			elseif inlist(grade, {'list', 'sia', 'si', 'sl'}) and args['list']~='no' then
				out = 'List'
			end
		elseif pagetype=='sia' then
				out = 'List'
So now if the pagetype is 'sia' then it always outputs "List", with no overriding. Given that that's the only change related to SIAs, I think that means that's what's causing the issue, that the line should be elseif pagetype=='sia' and args['list']~='no' then. It's not clear to me why Class mask has no option to output 'Sia', though. --PresN 14:13, 13 July 2026 (UTC)Reply
This did not fix it. Swapping out the {{Set index article}} template on the article for {{list of lists}} did. Was able to verify it was that by undoing and redoing the template swap; if you use the SIA template then bannershell no longer lets you set the class to SIA. Very weird, I don't see anything working differently in those two templates but I'll keep poking at it. --PresN 14:44, 19 July 2026 (UTC)Reply
It's because Module:Pagetype/setindex looks for templates to decide if it's really a set index, and "Set index article" is on the list, but "List of lists" is not. So the ultimate problem is in Module:Class mask treating different pagetypes differently, though I'm not sure how. --PresN 15:08, 19 July 2026 (UTC)Reply
Ok, finally fixed it. The logic was that if pagetype was 'article', then the condition that matched was that (class=SIA and the project's classmask allowed SIAs), then the output was 'SIA'. But if the pagetype was 'sia', then... nothing, you got 'List' or you got null. So, added the same checks as for 'article's, and can verify that I see projects that have opted in to SIA getting it (both in template and categories), while projects that haven't don't, and the overall bannershell continues to default to List. Kung Fu Man for awareness. --PresN 16:07, 19 July 2026 (UTC)Reply

Extra pipes

[edit]

I quite often see extra pipes being used in the syntax for this template, for example

{{WikiProject banner shell|blp=yes||class=C|
{{WikiProject Biography}}
}}

I think we could adapt the code so this would still work, i.e. use the 2nd positional parameter if the 1st is empty.  Martin (MSGJ · talk) 11:42, 25 June 2026 (UTC)Reply

Do not do that. We don't do that anywhere else on en.wiki and editors are familiar with that kind of code. This will just create inconsistencies and is also just wrong. Gonnym (talk) 10:46, 29 June 2026 (UTC)Reply
Instances of this will get captured by the MediaWiki-populated Category:Pages using duplicate arguments in template calls - I've taken to cleaning all Talk namespaces on a regular basis, so this doesn't require any special treatment in the template code. Besides, the last instance of the "1=" parameter is taken, so there's typically no negative effect on the rendered output. Harryboyles 07:17, 12 July 2026 (UTC)Reply
I was thinking of the case where the editor explictly puts |1= before the nested banners. In the original case above, it gets categorised in Category:WikiProject banner shell parameters needing attention instead, which I also clean up regularly.Harryboyles 07:33, 12 July 2026 (UTC)Reply
Okay, fair enough. We have enough people monitoring these categories now  Martin (MSGJ · talk) 21:26, 12 July 2026 (UTC)Reply

Inconsistent BLP settings

[edit]

Inconsistent BLP settings. Some editors have added {{BLP}} manually instead of using the parameter (see search results).

In Talk:Wiremu Kīngi Moki Te Matakātea for example, we have both the template and |blp=no (which is the correct one). Gonnym (talk) 10:48, 29 June 2026 (UTC)Reply

If we could get these cleaned up, then we could work on merging these templates (see Wikipedia:Templates for discussion/Log/2024 November 4#Template:BLP)  Martin (MSGJ · talk) 12:59, 29 June 2026 (UTC)Reply
Probably worth just forking them into the module so that these two templates will lose most of their transclusions, which will then make orphaning them easier. Gonnym (talk) 14:28, 29 June 2026 (UTC)Reply

Category:WikiProject banners placed outside the banner shell false negative

[edit]

Just found one from 2017: Old revision of Category talk:Films about Olympic equestrian sports.   ~ Tom.Reding (talkdgaf)  11:32, 15 July 2026 (UTC)Reply

Where is the bot told that {{WPEQ}} is a redirect for {{WikiProject Equine}}  Martin (MSGJ · talk) 14:57, 17 July 2026 (UTC)Reply
Oops, I forgot that the canonical name was required to check for in/exclusion. Cewbot has done so much work that I figured it would have already run over a page that old.   ~ Tom.Reding (talkdgaf)  15:54, 17 July 2026 (UTC)Reply